Skip to content

Comments

hid: asus-ally-hid: add the ROG ally driver#11

Open
NeroReflex wants to merge 17 commits intoOpenGamingCollective:ogc-6.19.yfrom
NeroReflex:ogc-6.19.y
Open

hid: asus-ally-hid: add the ROG ally driver#11
NeroReflex wants to merge 17 commits intoOpenGamingCollective:ogc-6.19.yfrom
NeroReflex:ogc-6.19.y

Conversation

@NeroReflex
Copy link

@NeroReflex NeroReflex commented Feb 19, 2026

This patchset add the ROG ally driver as in use on chachyos already.

This patch series is in development and is added to avoid regressing
ROG ally and ROG ally x devices, allowing InputPlumber to control the
device.

This driver is in development: the current form is unsuitable for upstream
because it creates a subtree in drivers/hid and because of various syntactic
thing to iron out.

Link: https://lore.kernel.org/all/[email protected]/

Copy link
Member

@pastaq pastaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the guidance listed here for PR's to the kernel as it makes updating the base version much easier.

https://github.com/OpenGamingCollective/organization-governance/blob/main/kernel/kernel_patching.md

Specifically, the patches should be labeled as [FOR-UPSTREAM] since this version is not yet on the ML.

@NeroReflex NeroReflex changed the title Add ROG Ally driver hid: asus-ally-hid: add the ROG ally driver Feb 19, 2026
@NeroReflex
Copy link
Author

git just strips the tag. No idea how to retain it

@pastaq
Copy link
Member

pastaq commented Feb 19, 2026

git just strips the tag. No idea how to retain it

Use git log to find the sha of the last commit before your series. Then change pick to reword for each commit and save/close the editor. This will open each commit message in your editor and you can make the changes there, then force push your branch when done.

@NeroReflex
Copy link
Author

git just strips the tag. No idea how to retain it

Use git log to find the sha of the last commit before your series. Then change pick to reword for each commit and save/close the editor. This will open each commit message in your editor and you can make the changes there, then force push your branch when done.

done

@pastaq
Copy link
Member

pastaq commented Feb 24, 2026

Please use [FOR-UPSTREAM] to indicate that it is a WIP driver that will be upstreamed eventually and not a hack we need to maintain until a new approach is found. Also please list the reason(s) why it hasn't been submitted yet in the top comment.

flukejones and others added 17 commits February 24, 2026 20:31
Adds basic support for the joystick RGB LED rings as a multicolour LED
device with 4 LEDs. As this uses the software-mode for setting the LED
colours it also sets the MCU-mode for LED's to static + the first RGB
colour on suspend/reboot/shutdown. This is done to prevent user confusion
if the LED's were to not match what was set, and to maintain consistency.

Signed-off-by: Luke D. Jones <[email protected]>
Export the validate_mcu_fw_version() symbol in namespace and use in
hid-asus-ally if the driver is enabled.

Signed-off-by: Luke Jones <[email protected]>
Enable use of the new gamepad device created by the MCU.
- Triggers
- Buttons
- Sticks
- Vibration

Signed-off-by: Luke D. Jones <[email protected]>
Add the basics of the gamepad configuration options. Makes the gamepad
usable.

Signed-off-by: Luke D. Jones <[email protected]>
Add the full set of button remapping abilities for plain remap and macro
remap (hold one button, press another for macro mapped action).

Signed-off-by: Luke D. Jones <[email protected]>
Add the mcu_version sysfs attribute so that userspace has a way to check
the MCU FW version.

Signed-off-by: Luke Jones <[email protected]>
The hid report for the QAM button changed on the ASUS ROG Xbox Ally X,
so add the new mapping for the short press event. Otherwise, all we get
is a long press event on "Asus Keyboard".

neptune:
We're carrying this as [NOT-FOR-UPSTREAM] because the last version of
hid-asus-ally on lkml was in August of 2024, and we have some divergence
from the last submission upstream. This should be included upstream when
there is a new submission for hid-asus-ally.

Reviewed-by: Derek J. Clark <[email protected]>
Signed-off-by: Matthew Schwartz <[email protected]>
With the current ROG Ally patchset, the MCU will send spurious events
when the ROG Ally is in s2idle while plugged in, which can cause the
system to wake unexpectedly.

There's really no reason the N-Key needs wakeup enabled, so just
disable the capability for now. This can be dropped when the issue is
root caused and fixed within the standard ROG Ally patchset.

Closes: ValveSoftware/SteamOS#2119
Signed-off-by: Matthew Schwartz <[email protected]>
@NeroReflex
Copy link
Author

Please use [FOR-UPSTREAM] to indicate that it is a WIP driver that will be upstreamed eventually and not a hack we need to maintain until a new approach is found. Also please list the reason(s) why it hasn't been submitted yet in the top comment.

done and done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants